Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move setting scanners when using compliance reports to flag parsing #6619

Conversation

DmitriyLewen
Copy link
Contributor

Description

when using compliance reports, we init some options before configuring the scanners (e.g. init trivy-db).
To avoid panic, we need to set up scanners when parsing flags.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this May 3, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review May 3, 2024 11:15
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner May 3, 2024 11:15
@knqyf263 knqyf263 enabled auto-merge May 3, 2024 11:17
@knqyf263 knqyf263 added this pull request to the merge queue May 3, 2024
Merged via the queue into aquasecurity:main with commit 14c1024 May 3, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the refactor/compliance-scanners-init-to-options branch May 3, 2024 12:14
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Image scanning panics when using certain combination of options
2 participants